Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: separate out tls feature flags #67

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

Fishrock123
Copy link
Member

A successor to #53, this separates out the tls feature flags, which should be nicer.

Fixes: #54

@Fishrock123
Copy link
Member Author

@JEnoch sorry for being slow, does this look good to you?

@JEnoch
Copy link
Contributor

JEnoch commented Feb 12, 2021

@Fishrock123 yes, looks good to me!
But I think the user doc shall make clear that using native-tls or rustls with something else than h1_client is probably not a good idea, right ? (or at best has no effect)

A successor to http-rs#53, this separates out the tls feature flags, which should be nicer.

Fixes: http-rs#54
@Fishrock123 Fishrock123 merged commit 7726816 into http-rs:main Feb 12, 2021
@Fishrock123 Fishrock123 deleted the rework-tls-features branch February 12, 2021 21:20
@taiki-e
Copy link
Contributor

taiki-e commented Feb 14, 2021

This seems to break when both "native-tls" feature and "rustls" feature are enabled, or when both "native-tls" feature and "rustls" feature are disabled.

  • "native-tls" feature and "rustls" feature are new features in 6.3, so this breaks all crates that using the "h1_client" feature and disabling the default features. (e.g., surf)
  • The cargo feature is shared across the dependency graph, so if both features are specified somewhere in the dependency graph, this breaks the build.

See also cargo reference: https://doc.rust-lang.org/nightly/cargo/reference/features.html

@taiki-e
Copy link
Contributor

taiki-e commented Feb 14, 2021

I filed a fix to surf (http-rs/surf#282), and I plan to send a similar patch to http-client later.

EDIT: filed #69 to fix http-client

@taiki-e taiki-e mentioned this pull request Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize feature flags to separate out different tls implementations
3 participants